[Intel-gfx] [PATCH 1/2] drm/i915: Add psr_enabled on pipe_config

[Rodrigo Vivi]

On Wed, Mar 25, 2015 at 12:04 AM, Sivakumar Thulasimani
<sivakumar.thulasimani at intel.com> wrote:
>
>> _crtc_state *pipe_config)
>>   {
>> @@ -5812,6 +5844,8 @@ static int intel_crtc_compute_config(struct
>> intel_crtc *crtc,
>>                 pipe_config->pipe_bpp = 8*3;
>>         }
>>   +     intel_compute_psr_config(crtc, pipe_config);
>> +
>>         if (HAS_IPS(dev))
>>                 hsw_compute_ips_config(crtc, pipe_config);
>>
>
> is it required to update psr_enabled during every call to
> intel_crtc_compute_config ? all conditions being checked will never change
> post init so it will be better to do this as part of eDP init rather than
> here.

Actually some of them depend on adjusted mode and other might depend
on s3d but also it is here to make sure all interdependencies and
pre-compute will be together. Besides, afaik this compute func
shouldn't be called many times.

Daniel, any thoughts?


>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br