[Intel-gfx] [PATCH] drm/i915: Attach a PSR property on eDP

[Chris Wilson]

On Wed, Mar 25, 2015 at 01:11:57PM -0700, Rodrigo Vivi wrote:
> From: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Let userspace know the status of Panel Self-Refresh by virtue of a
> property on the appropriate connector.
> 
> v2: Only attach the property if the driver is capable of PSR.
> v3: Add docbook courtesy of Damien.
> v4: Mark the initial value as 'unsupported' - it will be determined
>     correctly when we later read the DCPD from the panel.
> v5: Done by Rodrigo:
>     	 - Add disabled state to match all cases
> 	 - Attach it anyway to eDP since it is started as unsupported
> 	 - Change prop name to PSR
> 	 - Add enum to make states more clear
> 	 - Rebased on intel_psr.c changing func name and fixing states
> 
> +void intel_attach_psr_property(struct drm_connector *connector)
> +{
> +	struct drm_device *dev = connector->dev;
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct drm_property *prop;
> +
> +	prop = dev_priv->psr.property;
> +	if (prop == NULL) {
> +		prop = drm_property_create_enum(dev,
> +						DRM_MODE_PROP_ENUM |
> +						DRM_MODE_PROP_IMMUTABLE,
> +						"PSR",
> +						psr_names,
> +						ARRAY_SIZE(psr_names));

Are you sure you want the user visible string to be "PSR"? Googling
prefers "Panel Self-Refresh".
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre