[Intel-gfx] [PATCH 03/20] drm/i915: Allocate a drm_atomic_state for the legacy modeset code

Ander Conselvan De Oliveira conselvan2 at gmail.com
Fri Mar 27 02:05:05 PDT 2015


On Fri, 2015-03-27 at 10:01 +0100, Daniel Vetter wrote:
> On Fri, Mar 20, 2015 at 04:18:03PM +0200, Ander Conselvan de Oliveira wrote:
> > @@ -8924,6 +8932,11 @@ retry:
> >  	else
> >  		intel_crtc->new_config = NULL;
> >  fail_unlock:
> > +	if (state) {
> > +		drm_atomic_state_free(state);
> > +		state = NULL;
> > +	}
> 
> I think we should push the NULL handling into drm_atomic_state_free like
> with kfree. Can you please do such a patch on top of this for all of drm?

Sure, I'll do that.

Ander



More information about the Intel-gfx mailing list