[Intel-gfx] [PATCH] drm/i915: Simplify and fix object to display tracking

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 31 05:16:58 PDT 2015


On Tue, Mar 31, 2015 at 03:00:30PM +0300, Ville Syrjälä wrote:
> On Tue, Mar 31, 2015 at 12:10:04PM +0100, Tvrtko Ursulin wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 4ef320c..12388dd 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1969,7 +1969,8 @@ struct drm_i915_gem_object {
> >  	 */
> >  	unsigned int fault_mappable:1;
> >  	unsigned int pin_mappable:1;
> > -	unsigned int pin_display:1;
> > +	unsigned int pin_display:3;
> > +#define I915_MAX_PIN_DISPLAY 7
> 
> Why is that enough?

I had it split across two counters, which limited the number of times an
object could pinned to the display plane NUM_PLANES+1. I thought I was
saving space by using a few bits from a hole in the object and putting
the full counter on the vma.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list