[Intel-gfx] [PATCH 7/7] lib: add igt_draw

[Chris Wilson]

On Tue, Mar 31, 2015 at 06:52:08PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> For all those IGT tests that need an easy way to draw rectangles on
> buffers using different methods. Current planned users: FBC and PSR
> CRC tests.
> 
> There is also a tests/kms_draw_crc program to check if the library is
> sane.
> 
> v2: - Move the test from lib/tests to tests/ (Daniel).
>     - Add igt_require() to filter out the swizzling/tiling methods we
>       don't support (Daniel).
>     - Simplify reloc handling on the BLT case (Daniel).
>     - Document enum igt_draw_method (Daniel).
>     - Document igt_draw_get_method_name() (Paulo).

You are already missing one draw path (mmap wc), adding the extra swizzle
modes for anything but bit17 is trivial, the BLT code is an opencoded
intel_copy_bo and what is with all the sync? Moving everything into the
GTT write domain (i.e. manually doing cache flushes) would seem to
nullify the point of using the GPU in the first place.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre