[Intel-gfx] [PATCH] drm/i915: Demote hangcheck ring idle warning

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed May 6 02:40:40 PDT 2015


Currently we have race between request->list addition
and hangcheck inspecting that list. It leads to hangcheck
concluding that ring is idle, even if its not.

Demote the error to a info message until the issue with
race is fixed.

References: https://bugs.freedesktop.org/show_bug.cgi?id=89493
References: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060545.html
Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 9da955e..b0fec20 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2925,8 +2925,8 @@ static void i915_hangcheck_elapsed(struct work_struct *work)
 					/* Issue a wake-up to catch stuck h/w. */
 					if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_irq_rings)) {
 						if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(ring)))
-							DRM_ERROR("Hangcheck timer elapsed... %s idle\n",
-								  ring->name);
+							DRM_INFO("Hangcheck timer elapsed... %s idle\n",
+								 ring->name);
 						else
 							DRM_INFO("Fake missed irq on %s\n",
 								 ring->name);
-- 
1.9.1



More information about the Intel-gfx mailing list