[Intel-gfx] [PATCH 8/8] drm/i915/skl: gen6+ platforms support runtime PM

[Damien Lespiau]

On Wed, May 06, 2015 at 12:54:23PM +0200, Daniel Vetter wrote:
> On Thu, Apr 30, 2015 at 04:39:23PM +0100, Damien Lespiau wrote:
> > Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index f637667..25618fd 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2422,8 +2422,7 @@ struct drm_i915_cmd_table {
> >  #define HAS_PSR(dev)		(IS_HASWELL(dev) || IS_BROADWELL(dev) || \
> >  				 IS_VALLEYVIEW(dev) || IS_CHERRYVIEW(dev) || \
> >  				 IS_SKYLAKE(dev))
> > -#define HAS_RUNTIME_PM(dev)	(IS_GEN6(dev) || IS_HASWELL(dev) || \
> > -				 IS_BROADWELL(dev) || IS_VALLEYVIEW(dev))
> > +#define HAS_RUNTIME_PM(dev)	(INTEL_INFO(dev)->gen >= 6)
> >  #define HAS_RC6(dev)		(INTEL_INFO(dev)->gen >= 6)
> >  #define HAS_RC6p(dev)		(INTEL_INFO(dev)->gen == 6 || IS_IVYBRIDGE(dev))
> 
> iirc ilk fdi lane sharing won't get restored correctly, at least that was
> the case way back. Have you double-checked that that still works on an
> ivb? Ander has a testcase and setup for it ...

It wasn't my intention at all to change the behaviour here, I just
forgot about IVB...

As it was just to reduce the number of conditions, might as well make it
a device info flag.

-- 
Damien