[Intel-gfx] [PATCH i-g-t] tests/gem_mmap_gtt(huge_bo): Use pread more to verify domain transfer.

Chris Wilson chris at chris-wilson.co.uk
Wed May 6 06:15:24 PDT 2015


On Wed, May 06, 2015 at 03:31:10PM +0300, Joonas Lahtinen wrote:
> 
> Use pread right after moving out of CPU domain to verify all
> writes flushed correctly.

Wrong test, see gem_pread. Adding extra work may have the unintended
side-effects of masking bugs. If you want to mix access modes, call it a
new test, and that is handled by gem_concurrent_blt (which once again is
difting far beyond the original name).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list