[Intel-gfx] [PATCH 3/3] drm/i915/bxt: Add WaForceContextSaveRestoreNonCoherent

[Imre Deak]

On Wed, 2015-05-06 at 17:01 +0100, Nick Hoath wrote:
> On 29/04/2015 14:02, Deak, Imre wrote:
> > On pe, 2015-04-10 at 13:12 +0100, Nick Hoath wrote:
> >> Signed-off-by: Nick Hoath <nicholas.hoath at intel.com>
> >> ---
> >>   drivers/gpu/drm/i915/intel_ringbuffer.c | 5 +++++
> >>   1 file changed, 5 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >> index eebee73..cc62e5c 100644
> >> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> >> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> >> @@ -1054,6 +1054,10 @@ static int bxt_init_workarounds(struct intel_engine_cs *ring)
> >>   			GEN7_SBE_SS_CACHE_DISPATCH_PORT_SHARING_DISABLE);
> >>   	}
> >>
> >> +	/* WaForceContextSaveRestoreNonCoherent:bxt */
> >> +	WA_SET_BIT_MASKED(HDC_CHICKEN0,
> >> +			  HDC_FORCE_CONTEXT_SAVE_RESTORE_NON_COHERENT);
> >> +
> >
> > Looks ok, but again it needs to be added for SKL (all steppings) in
> > gen9_init_workarounds.
> 
> The same argument as for patch 2/3 applies?

Yes, applying this on SKL as a follow up is ok:

Reviewed-by: Imre Deak <imre.deak at intel.com>