[Intel-gfx] [PATCH] drm/i915: Warn when execlists changes context without IRQs

[Daniel Vetter]

On Mon, May 11, 2015 at 09:26:40PM +0100, Chris Wilson wrote:
> On Mon, May 11, 2015 at 06:37:14PM +0200, Daniel Vetter wrote:
> > On Mon, May 11, 2015 at 04:03:27PM +0100, Peter Antoine wrote:
> > > If an batch ends while the IRQs are not turned on the notification can
> > > go missing and the GPU can hang. So generate a warning in this case.
> > > 
> > > Signed-off-by: Peter Antoine <peter.antoine at intel.com>
> > 
> > Queued for -next, thanks for the patch.
> 
> Please drop this. We already have the test inside the irq handler. The
> instance where you want the guard is during resume, inside
> intel_lr_context_render_state_init() where you can even emit an error
> code!

_unqueue is also called from intel_logical_ring_advance_and_submit and
should cover us I hope. And I don't think we should add error handling for
this, that has cost of its own.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch