[Intel-gfx] [PATCH] Documentation/drm: Update rotation property with 90/270 and description

[Ville Syrjälä]

On Wed, Apr 15, 2015 at 04:05:19PM +0530, Sonika Jindal wrote:
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Sonika Jindal <sonika.jindal at intel.com>
> ---
>  Documentation/DocBook/drm.tmpl |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index f4976cd..266d50a 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2853,9 +2853,12 @@ void intel_crt_init(struct drm_device *dev)
>  	<td rowspan="1" valign="top" >Plane</td>
>  	<td valign="top" >“rotation”</td>
>  	<td valign="top" >BITMASK</td>
> -	<td valign="top" >{ 0, "rotate-0" }, { 2, "rotate-180" }</td>
> +	<td valign="top" >{ 0, "rotate-0" }, { 1, "rotate-90" },
> +				{ 2, "rotate-180" }, { 3, "rotate-270" }</td>
>  	<td valign="top" >Plane</td>
> -	<td valign="top" >TBD</td>
> +	<td valign="top" >To set plane HW rotation. This rotation property does
> +		the plane rotation in counter clockwise direction which is
> +		inline with the way XRandr works.</td>

I would suggest moving the thing to the generci props section since we
have omap and i915 both supporting it.

As for the description, we should also document the reflect flags.

I might write it as something like this:
"rotate-0,rotate-90,rotate-180,rotate-270 rotate the image by the
specified amount in degrees in a counter clockwise direction.
reflect-x,reflect-y reflect the image along the specified axis,
prior to rotation."

>  	</tr>
>  	<tr>
>  	<td rowspan="17" valign="top" >SDVO-TV</td>
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC