[Intel-gfx] [PATCH 1/2] drm/i915: Dump some DPLL fields in pipe config debug

[Daniel Vetter]

On Wed, May 13, 2015 at 05:41:40PM +0100, Damien Lespiau wrote:
> On Wed, May 13, 2015 at 04:51:07PM +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > 
> > Tried to get the platform split right, please shout if I failed.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> So, previously, we used to dump the whole list of states, even when the
> platform didn't care about all of them. I do like a platform-aware dump
> of the state better and this looks right to me (surely we can break the
> strings at a ','!).
> 
> You probably also want to add pipe_config->ddi_pll_sel on DDI platforms
> as it encodes the actual PLL selection (at least) and maybe look at the
> other DPLL-related states in there (I can give a r-b tag without those
> :p)
> 
> A small typo below.

Not convinced, for the same reason that we don't have platform checks
(except where absolutely necessary) in the pipe_config_compare code: No
one will notice bug here until it's too late. Otoh the pipe dump code
always seems to be lacking.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch