[Intel-gfx] [PATCH] drm/i915/hsw: Fix workaround for server AUX channel clock divisor

jim.bride at linux.intel.com jim.bride at linux.intel.com
Tue May 19 09:13:30 PDT 2015


From: Jim Bride <jim.bride at linux.intel.com>

According to the HSW b-spec we need to try clock divisors of 63
and 72, each 3 or more times, when attempting DP AUX channel
communication on a server chipset.  This actually wasn't happening
due to a short-circuit that only checked the DP_AUX_CH_CTL_DONE bit
in status rather than checking that the operation was done and
that DP_AUX_CH_CTL_TIME_OUT_ERROR was not set.

Signed-off-by: Jim Bride <jim.bride at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 0edc305..c01a3f9 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -895,7 +895,8 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 			if (status & DP_AUX_CH_CTL_DONE)
 				break;
 		}
-		if (status & DP_AUX_CH_CTL_DONE)
+		if ((status & DP_AUX_CH_CTL_DONE) &&
+		    !(status & DP_AUX_CH_CTL_TIME_OUT_ERROR))
 			break;
 	}
 
-- 
1.9.1



More information about the Intel-gfx mailing list