[Intel-gfx] [PATCH] drm/i915: Update comment in clear_intel_crtc_state()

[Daniel Vetter]

On Wed, May 20, 2015 at 10:43:20AM +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2015-05-20 at 10:37 +0300, Jani Nikula wrote:
> > On Wed, 20 May 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com> wrote:
> > > Explain why a few fields of the new pipe_config have their values
> > > preserved, while the others are zeroed.
> > >
> > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_display.c | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > > index a7732b4..b0cd649 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -11460,7 +11460,11 @@ clear_intel_crtc_state(struct intel_crtc_state *crtc_state)
> > >  	enum intel_dpll_id shared_dpll;
> > >  	uint32_t ddi_pll_sel;
> > >  
> > > -	/* Clear only the intel specific part of the crtc state excluding scalers */
> > > +	/* FIXME: before the switch to atomic started, a new pipe_config was
> > > +	 * kzalloc'd. Code that depends on any field being zero should be
> > > +	 * fixed, so that the crtc_state can be safely duplicated. For now,
> > > +	 * only fields that are know to not cause problems are preserved. */
> > > +
> > 
> > Nitpick, the opening /* and at least the closing */ should be on their
> > own lines.
> 
> I've seen a mix of both styles through-out the driver, so it wasn't
> clear to me that's preferred. I'll follow that from now on.

Yeah i915 isn't consistent about this at all. Whatever floats the boat
applies here ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch