[Intel-gfx] [PATCH] drm/i915: Force clean compilation with -Werror

Chris Wilson chris at chris-wilson.co.uk
Wed May 20 07:44:56 PDT 2015


On Wed, May 20, 2015 at 02:55:35PM +0100, Damien Lespiau wrote:
> On Wed, May 20, 2015 at 02:12:47PM +0100, Chris Wilson wrote:
> > Our driver compiles clean (nowadays thanks to 0day) but for me, at least,
> > it would be beneficial if the compiler threw an error rather than a
> > warning when it found a piece of suspect code. (I use this to
> > compile-check patch series and want to break on the first compiler error
> > in order to fix the patch.)
> > 
> > v2: Kick off a new "Debugging" submenu for i915.ko
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> I believe we could shove a few interesting things into that menu, sounds
> like a potentially useful thing to me:
> 
> Acked-by: Damien Lespiau <damien.lespiau at intel.com>
> 
> -- 
> Damien
> 
> > ---
> >  drivers/gpu/drm/i915/Kconfig       | 8 ++++++++
> >  drivers/gpu/drm/i915/Kconfig.debug | 5 +++++
> >  drivers/gpu/drm/i915/Makefile      | 2 ++
> >  3 files changed, 15 insertions(+)
> >  create mode 100644 drivers/gpu/drm/i915/Kconfig.debug
> > 
> > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> > index 74acca9bcd9d..76c425ca2a2c 100644
> > --- a/drivers/gpu/drm/i915/Kconfig
> > +++ b/drivers/gpu/drm/i915/Kconfig
> > @@ -71,3 +71,11 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT
> >  	  option changes the default for that module option.
> >  
> >  	  If in doubt, say "N".
> > +
> > +menu "Debugging"

This has to be something more like "DRM I915_Debugging" as it is
presented to the user without context in make oldconfig and appears
verbatim in .config.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list