[Intel-gfx] [PATCH 01/12] drm/i915: Remove a bogus 12bpc "toggle" from intel_disable_hdmi()

[Jesse Barnes]

On 05/05/2015 07:17 AM, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The IBX 12bpc port enable toggle is only relevant when enabling
> the port, not when disabling it. Also this code doesn't actually
> toggle anything, and essentially just writes the port register
> one extra time. Furthermore CPT/PPT don't need such workarounds
> and yet we include them. Just kill it.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index f3eec38..72fce34 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1127,14 +1127,6 @@ static void intel_disable_hdmi(struct intel_encoder *encoder)
>  		}
>  	}
>  
> -	/* HW workaround, need to toggle enable bit off and on for 12bpc, but
> -	 * we do this anyway which shows more stable in testing.
> -	 */
> -	if (HAS_PCH_SPLIT(dev)) {
> -		I915_WRITE(intel_hdmi->hdmi_reg, temp & ~SDVO_ENABLE);
> -		POSTING_READ(intel_hdmi->hdmi_reg);
> -	}
> -
>  	temp &= ~enable_bits;
>  
>  	I915_WRITE(intel_hdmi->hdmi_reg, temp);
> 

Testing wins.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>