[Intel-gfx] [PATCH] drm/i915: Fix locking around GuC firmware load

Yu Dai yu.dai at intel.com
Wed Nov 4 08:47:12 PST 2015


On 11/03/2015 07:22 PM, Dave Airlie wrote:
> On 4 November 2015 at 07:42, Daniel Stone <daniels at collabora.com> wrote:
> > The GuC firmware load requires struct_mutex to create a GEM object,
> > but this collides badly with request_firmware. Move struct_mutex
> > locking down into the loader itself, so we don't hold it across the
> > entire load process, including request_firmware.
> >
> > Signed-off-by: Daniel Stone <daniels at collabora.com>
>
> This avoids the lockdep spew on my machine.
>
> Reviewed-by: Dave AIrlie <airlied at redhat.com>
>
> I'm going to put this into -next, granted I've still got the other WARN spew
> but lockdep working is a good start.
>
>

Looks good to me. Thanks for the fix.

Reviewed-by: Alex Dai <yu.dai at intel.com>

Alex


More information about the Intel-gfx mailing list