[Intel-gfx] [PATCH 26/29] drm/i915: Add 'offset' to uncore funcs

[Ville Syrjälä]

On Thu, Nov 05, 2015 at 10:16:00AM +0000, Chris Wilson wrote:
> On Wed, Nov 04, 2015 at 11:20:14PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Add 'uint32_t offset' to the uncore register access functions. For now
> > it's the same as 'reg', but once type safety gets added 'reg' will be
> > the type safe register variable and 'offset' the raw offset.
> 
> I presume this is patch 29? (I don't see patch 29/29 :(

I presume you since saw 29/29 because you commented on it :)

> 
> But when did we start using off_t? Why would we use a uAPI typedef for an
> internal type? I can't wait for you to kill it with fire.

Looks like

commit 0b27448141bbe9da34a2fdf965dcba6f0f1b75c5
Author: Ben Widawsky <benjamin.widawsky at intel.com>
Date:   Fri Oct 4 21:22:51 2013 -0700

    drm/i915: Create MMIO virtual functions

> 
> We are mixing lots of uint32_t/u32 here. But the premise of the patch is
> sound.

I think a lot of people were moving towards uint32_t in recent times,
or at least I was. But given the recent Linus rant, I'm not sure if
we should reverse that direction and just try to stick to u32?

-- 
Ville Syrjälä
Intel OTC