[Intel-gfx] [PATCH 23/29] drm/i915: Wrap context LRI init in a macro

Chris Wilson chris at chris-wilson.co.uk
Thu Nov 5 05:49:09 PST 2015


On Wed, Nov 04, 2015 at 11:20:11PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We set up a load of LRIs in the logical ring context. Wrap that stuff
> in a macro to avoid typos with position of each reg/value pair in the
> context. This also makes it easier to make the register defines type
> safe.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Beat me to it.

Sometimes I like being a little evil and hiding the constant parameter
passing, especially if it is localised to a single function and never
going to escape.

Fwiw,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
and consequently for the previous patch as well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list