[Intel-gfx] [PATCH] drm/i915/skl: implement DP Aux Mutex framework

[Dave Airlie]

On 10 November 2015 at 20:51, Jani Nikula <jani.nikula at linux.intel.com> wrote:
> On Tue, 10 Nov 2015, Wayne Boyer <wayne.boyer at intel.com> wrote:
>> Beginning with SKL the DP Aux channel communication can be protected
>> using a built in H/W mutex.
>>
>> This patch provides an initial implementation for using that mutex.
>> The use is currently limited to protecting the sink crc request based
>> on feedback from the H/W designers indicating that using the mutex
>> for all aux channel communication is not recommended.
>
> Please explain in the commit message what benefits this brings, and why
> it's a good idea. Just that something *can* be done in hardware does not
> mean that we should do it.

I also have trouble understanding a mutex that only some things use. Seems
like a mutex needs to be used everywhere to provide locking.


Dave.