[Intel-gfx] [PATCH 3/3] drm/i915: Use insert_page for pwrite_fast

[Chris Wilson]

On Tue, Nov 10, 2015 at 08:44:59AM +0000, Chris Wilson wrote:
> On Tue, Nov 10, 2015 at 09:55:18AM +0200, Mika Kuoppala wrote:
> > > +	while (remain) {
> > >  		/* Operation in this page
> > >  		 *
> > >  		 * page_base = page offset within aperture
> > >  		 * page_offset = offset within page
> > >  		 * page_length = bytes to copy for this page
> > >  		 */
> > > -		page_base = offset & PAGE_MASK;
> > > -		page_offset = offset_in_page(offset);
> > > -		page_length = remain;
> > > -		if ((page_offset + remain) > PAGE_SIZE)
> > > -			page_length = PAGE_SIZE - page_offset;
> > > -
> > > +		u32 page_base = node.start;
> > 
> > You truncate here as node.start is 64bit offset into the vm area.
> 
> It's a bit of cheat since it can't be 64bit, but the code is equally
> inconsistent. The io-mapping can only handle unsigned long.

And for reference, it is preserving current behaviour.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre