[Intel-gfx] [PATCH] drm/i915: Remove redundant check in i915_gem_obj_to_vma

Chris Wilson chris at chris-wilson.co.uk
Thu Nov 12 04:29:38 PST 2015


On Thu, Nov 12, 2015 at 11:59:55AM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> No need to verify VMA belongs to GGTT since:
> 
> 1. The function must return a normal VMA belonging to passed in VM.
> 2. There can only be one normal VMA for any VM.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by Chris Wilson <chris at chris-wilson.co.uk>

> Maybe now even a candidate for making a static inline?

No. After tracking vma, i915_gem_obj_to_vma() is moved off the hotpaths
and mostly used for the first lookup by an execbuffer, context creation,
modesetting and debug code.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list