[Intel-gfx] [PATCH 2/4] drm/i915: Clarify plane state during CRTC state dumps

[Ville Syrjälä]

On Thu, Nov 12, 2015 at 04:31:57PM -0800, Matt Roper wrote:
> During state dumping, list planes that have an FB but are invisible
> (e.g., because they're offscreen or clipped by other planes) as "not
> visible" rather than "enabled."  While we're at it, throw the bpp value
> into the debugging output.
> 
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7bbcb98..d994f52 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12102,13 +12102,15 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
>  			continue;
>  		}
>  
> -		DRM_DEBUG_KMS("%s PLANE:%d plane: %u.%u idx: %d enabled",
> +		DRM_DEBUG_KMS("%s PLANE:%d plane: %u.%u idx: %d %s",
>  			plane->type == DRM_PLANE_TYPE_CURSOR ? "CURSOR" : "STANDARD",
>  			plane->base.id, intel_plane->pipe,
>  			crtc->base.primary == plane ? 0 : intel_plane->plane + 1,
> -			drm_plane_index(plane));
> -		DRM_DEBUG_KMS("\tFB:%d, fb = %ux%u format = 0x%x",
> -			fb->base.id, fb->width, fb->height, fb->pixel_format);
> +			drm_plane_index(plane),
> +			state->visible ? "enabled" : "not visible");
> +		DRM_DEBUG_KMS("\tFB:%d, fb = %ux%u format = 0x%x bpp = %d",
> +			fb->base.id, fb->width, fb->height, fb->pixel_format,
> +			fb->bits_per_pixel);

Let's try to avoid bits_per_pixel shall we. It's not even populated for
YCbCr formats. We print the format here already so I think it should be
enough. But we should dump in using drm_get_format_name().

>  		DRM_DEBUG_KMS("\tscaler:%d src (%u, %u) %ux%u dst (%u, %u) %ux%u\n",
>  			state->scaler_id,
>  			state->src.x1 >> 16, state->src.y1 >> 16,
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC