[Intel-gfx] [PATCH i-g-t 1/3] tests: use igt_assert_lte to verify pm_backlight test results
Jani Nikula
jani.nikula at intel.com
Wed Nov 18 04:57:10 PST 2015
Gives out better diagnostics than just igt_asssert.
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
tests/pm_backlight.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
index d24fb1034198..bdc0e33de94c 100644
--- a/tests/pm_backlight.c
+++ b/tests/pm_backlight.c
@@ -94,6 +94,7 @@ static int backlight_write(int value, const char *fname)
static void test_and_verify(int val)
{
int result;
+ int tolerance = val * TOLERANCE / 100;
igt_assert_eq(backlight_write(val, "brightness"), 0);
igt_assert_eq(backlight_read(&result, "brightness"), 0);
@@ -102,7 +103,8 @@ static void test_and_verify(int val)
igt_assert_eq(backlight_read(&result, "actual_brightness"), 0);
/* Some rounding may happen depending on hw. Just check that it's close enough. */
- igt_assert(result <= val + val * TOLERANCE / 100 && result >= val - val * TOLERANCE / 100);
+ igt_assert_lte(result, val + tolerance);
+ igt_assert_lte(val - tolerance, result);
}
static void test_brightness(int max)
--
2.1.4
More information about the Intel-gfx
mailing list