[Intel-gfx] [PATCH 0/5] Sink CRC stabilization

Daniel Vetter daniel at ffwll.ch
Wed Nov 18 06:55:07 PST 2015


On Mon, Nov 16, 2015 at 03:59:15PM +0000, Rodrigo Vivi wrote:
> Hi Daniel,
> 
> could you please ignore patch 5 in this series and merge the 4 first
> patches.

I merged an earlier instance of the first 4 patches. Has anything changed?
Please double-check the right versions landed in dinq.

Thanks, Daniel

> 
> The aux mutex is really unreliable and doesn't help on all SKLs so better
> to just ignore that.
> 
> Thanks,
> Rodrigo.
> 
> On Thu, Nov 12, 2015 at 11:03 AM Rodrigo Vivi <rodrigo.vivi at gmail.com>
> wrote:
> 
> > On Thu, Nov 12, 2015 at 10:56 AM Vivi, Rodrigo <rodrigo.vivi at intel.com>
> > wrote:
> >
> >> On Thu, 2015-11-12 at 12:17 +0200, Jani Nikula wrote:
> >> > On Wed, 11 Nov 2015, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> >> > > Let's start spliting that big series that enables PSR with this
> >> > > sink crc
> >> > > stabilization.
> >> > >
> >> > > Also I'm adding Wayne's mutex that stabilizes sink CRC on Skylake.
> >> > >
> >> > > All patches already reviewed and ready to merge.
> >> >
> >> > Disagreed on the hw mutex patch.
> >>
> >> I wasn't considered it as nacked. But it seems that we have more to
> >> discuss around it.
> >>
> >> Although I don't see a reason of blocking a patch that follow spec, it
> >> is reviewed, and it is used to fix a bug, unblock validation and only
> >> used for the particular case that is just used on automated validation
> >> and not broadly to all aux communications.
> >>
> >
> > Oh, now I saw you had comments there on the patch. So please ignore this
> > complain and accept my apologies.
> >
> >
> >>
> >> >
> >> > BR,
> >> > Jani.
> >> >
> >> > >
> >> > > Thank you very much Paulo for the review and Thank you Wayne for
> >> > > the
> >> > > SKL aux mutex.
> >> > >
> >> > > Thanks,
> >> > > Rodrigo.
> >> > >
> >> > > Boyer, Wayne (1):
> >> > >   drm/i915/skl: implement DP Aux Mutex framework
> >> > >
> >> > > Rodrigo Vivi (4):
> >> > >   drm/i915: Allow 1 vblank to let Sink CRC calculation to start or
> >> > > stop.
> >> > >   drm/i915: Make Sink crc calculation waiting for counter to reset.
> >> > >   drm/i915: Stop tracking last calculated Sink CRC.
> >> > >   drm/i915: Rely on TEST_SINK_START instead of tracking Sink CRC
> >> > > state
> >> > >     on dev_priv.
> >> > >
> >> > >  drivers/gpu/drm/i915/i915_drv.h  |   1 +
> >> > >  drivers/gpu/drm/i915/i915_reg.h  |   5 ++
> >> > >  drivers/gpu/drm/i915/intel_dp.c  | 126 +++++++++++++++++++++++++++
> >> > > ------------
> >> > >  drivers/gpu/drm/i915/intel_drv.h |   7 ---
> >> > >  4 files changed, 93 insertions(+), 46 deletions(-)
> >> >
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >>
> >

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list