[Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

Daniel Stone daniel at fooishbar.org
Tue Nov 24 05:29:07 PST 2015


Hi,

On 24 November 2015 at 13:27, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Tue, Nov 24, 2015 at 01:17:57PM +0000, Tvrtko Ursulin wrote:
>> On 24/11/15 12:53, Chris Wilson wrote:
>> >The WARN_ON is accurate though. The original patch fails to fix even the
>> >limited aspect of the bug it claimed to.
>>
>> That is not true. It only makes it a bit more limited, and not by
>> its fault even. Even with that it makes things a bit better, not
>> worse.
>
> It makes the code worse for very limited improvement, for which we did
> not have a publically reported bug, i.e. the impact is very small.

I can get the person who reported it to me to raise a Bugzilla
complaining about the WARN_ON if you like ...

Cheers,
Daniel


More information about the Intel-gfx mailing list