[Intel-gfx] [PATCH 04/12] drm/i915: Unify intel_ring_begin()

[Chris Wilson]

On Tue, Nov 24, 2015 at 03:38:46PM +0100, Daniel Vetter wrote:
> On Fri, Nov 20, 2015 at 12:43:44PM +0000, Chris Wilson wrote:
> > Combine the near identical implementations of intel_logical_ring_begin()
> > and intel_ring_begin() - the only difference is that the logical wait
> > has to check for a matching ring (which is assumed by legacy).
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Hm, I originally punted on this one since OCD-me wanted to move
> engine->request_list to ring->request_list first. But hey just adding the
> check works too and gives us the immediate improvement faster!

I was too lazy to add the breadcrumb list I used last time. Or rather, I
used that list for more than just wait_for_space() and didn't want to
try and get the whole semaphore/interrupt mitigation reviewed. There is
still the complaint for media wakeups caused by our breadcrumb being too
heavy handed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre