[Intel-gfx] [PATCH] drm/i915: Don't use crtc->config when reading out infoframe state

Jani Nikula jani.nikula at linux.intel.com
Fri Nov 27 00:41:09 PST 2015


Not strictly related to this patch.

On Thu, 26 Nov 2015, ville.syrjala at linux.intel.com wrote:
> The .get_config() hooks should not reference anything in crtc->config,
> everything should be based on the passed in pipe_config instead.

This is the kind of authoritative comment that I would appreciate seeing
in the kernel-doc for the hooks in struct intel_encoder. We have
practically nothing of the sort. We still seem to rely more on oral
tradition than actual documentation. (Not that there's anything wrong
with oral tradition per se, it's just that we don't regularly sit around
campfires reciting encoder hook rules or make folk songs about them.)

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list