[Intel-gfx] [PATCH 1/2] drm/i915: Kill DRI1 cliprects

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Oct 6 07:19:36 PDT 2015

On 06/10/15 11:39, Chris Wilson wrote:
> Passing cliprects into the kernel for it to re-execute the batch buffer
> with different CMD_DRAWRECT died out long ago. As DRI1 support has been
> removed from the kernel, we can now simply reject any execbuf trying to
> use this "feature".
> To keep Daniel happy with the prospect of being able to reuse these
> fields in the next decade, continue to ensure that current userspace is
> not passing garbage in through the dead fields.
> v2: Fix the cliprects_ptr check
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>

Don't know anything about the DRI1 history but the removal looks fine to 
me, so:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Would it also make sense to rename the related fields in 
drm_i915_gem_execbuffer2 to reserved?



More information about the Intel-gfx mailing list