[Intel-gfx] [PATCH] drm/i915: Set mode->crtc_clock during hardware state readout

Matt Roper matthew.d.roper at intel.com
Tue Oct 6 09:26:31 PDT 2015

intel_mode_from_pipe_config() fills in a mode structure from the CRTC
state that was read out of the hardware, but does not set the
.crtc_clock field (it only sets the .clock).  This causes the subsequent
call to drm_calc_timestamping_constants() to complain with messages like
"*ERROR* crtc 21: Can't calculate constants, dotclock = 0!"  Ensuring
.crtc_clock is set as well eliminates this error.

Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
 drivers/gpu/drm/i915/intel_display.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index bbeb6d3..4e481e3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7752,6 +7752,7 @@ void intel_mode_from_pipe_config(struct drm_display_mode *mode,
 	mode->type = DRM_MODE_TYPE_DRIVER;
 	mode->clock = pipe_config->base.adjusted_mode.crtc_clock;
+	mode->crtc_clock = pipe_config->base.adjusted_mode.crtc_clock;
 	mode->flags |= pipe_config->base.adjusted_mode.flags;
 	mode->hsync = drm_mode_hsync(mode);

More information about the Intel-gfx mailing list