[Intel-gfx] [PATCH 6/9] drm/i915: driver based PASID handling

[David Woodhouse]

On Fri, 2015-09-04 at 09:59 -0700, Jesse Barnes wrote:
> +
> +       ret = handle_mm_fault(mm, vma, address,
> +                             desc.wr_req ? FAULT_FLAG_WRITE : 0);
> +       if (ret & VM_FAULT_ERROR) {
> +               gpu_mm_segv(tsk, address, SEGV_ACCERR); /* ? */
> +               goto out_unlock;
> +       }
> +

Hm, do you need to force the SEGV there, in what ought to be generic
IOMMU code?

Can you instead just let the fault handler return an appropriate
failure code to the IOMMU request queue and then deal with the
resulting error on the i915 device side?

That way, you should hopefully get to gracefully cope with reporting
errors for a specific *context*, rather than killing the whole process.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5691 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20151007/7c5ad23a/attachment-0001.bin>