[Intel-gfx] [PATCH 3/3] drm/i915: add DOC for i915_component

Daniel Vetter daniel at ffwll.ch
Wed Oct 7 06:39:11 PDT 2015


On Wed, Oct 07, 2015 at 07:47:09AM +0000, Yang, Libin wrote:
> Hi all,
> 
> Any comments? Thanks.

Was simply held up with some merge ordering troubles, I had to wait for
Takashi to apply the last patch so I could do a backmerge. And then I
forget about your patch series, thanks a lot for the reminder.

I applied them to dinq, with patches 2&3 squashed together.

Thanks, Daniel

> 
> Regards,
> Libin
> 
> > -----Original Message-----
> > From: Yang, Libin
> > Sent: Thursday, October 01, 2015 5:01 PM
> > To: intel-gfx at lists.freedesktop.org; daniel.vetter at ffwll.ch;
> > jani.nikula at linux.intel.com; ville.syrjala at linux.intel.com
> > Cc: Yang, Libin
> > Subject: [PATCH 3/3] drm/i915: add DOC for i915_component
> > 
> > From: Libin Yang <libin.yang at intel.com>
> > 
> > Add the DOC for i915_component.h. Explain the struct
> > i915_audio_component_ops and struct
> > i915_audio_component_audio_ops
> > usage.
> > 
> > Signed-off-by: Libin Yang <libin.yang at intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_audio.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c
> > b/drivers/gpu/drm/i915/intel_audio.c
> > index 72d696b..56c2f54 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -50,6 +50,11 @@
> >   * co-operation between the graphics and audio drivers is handled via
> > audio
> >   * related registers. (The notable exception is the power management,
> > not
> >   * covered here.)
> > + *
> > + * The struct i915_audio_component is used to interact between the
> > graphics
> > + * and audio drivers. The struct i915_audio_component_ops *ops in it
> > is
> > + * defined in graphics driver and called in audio driver. The
> > + * struct i915_audio_component_audio_ops *audio_ops is called
> > from i915 driver.
> >   */
> > 
> >  static const struct {
> > --
> > 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list