[Intel-gfx] [PATCH] igt/kms_addfb_basic: New subtest to check for fb modifier and tiling mode mismatch

[Tvrtko Ursulin]

Hi,

On 07/10/15 03:35, Vivek Kasireddy wrote:
> This new subtest will validate a Y-tiled object's tiling mode against
> its associated fb modifier.
>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy at intel.com>
> ---
>   tests/kms_addfb_basic.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index d466e4d..7ca1add 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -373,6 +373,15 @@ static void addfb25_ytile(int fd, int gen)
>   		f.handles[0] = gem_bo;
>   	}
>
> +	igt_subtest("addfb25-Y-tiled-X-modifier-mismatch") {
> +		igt_require(gen >= 9);
> +		igt_require_fb_modifiers(fd);
> +		gem_set_tiling(fd, gem_bo, I915_TILING_Y, 1024*4);
> +
> +		f.modifier[0] = LOCAL_I915_FORMAT_MOD_X_TILED;
> +		igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) < 0 && errno == EINVAL);
> +	}
> +
>   	igt_subtest("addfb25-Y-tiled") {
>   		igt_require_fb_modifiers(fd);
>

Wasn't the original WARN triggered by Y tiled object and Y fb modifier?

Regards,

Tvrtko