[Intel-gfx] [PATCH 2/3] drm/i915/vlv: remove pre-production hardware workaround

[Daniel Vetter]

On Wed, Oct 07, 2015 at 04:27:24PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 07, 2015 at 11:17:45AM +0300, Jani Nikula wrote:
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_gem_gtt.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 620d57e2526b..4e328f71a454 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -133,13 +133,6 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> >  	}
> >  #endif
> >  
> > -	/* Early VLV doesn't have this */
> > -	if (IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) &&
> > -	    dev->pdev->revision < 0xb) {
> > -		DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
> > -		return 0;
> > -	}
> 
> IIRC B2 may have gotten out into the wild, so we can't kill this check
> unfortunately. Well, unless it magically got fixed in the meantime. I
> don't think anyone ever figured out what the problems was with PPGTT on
> B2 and earlier.

Note "into the wild" isn't valid imo - we've had snb workarounds that we
killed which made a few sdvs used by distros and oems broken. I applied it
anyway.

It's only for stuff that's sold in general that I'm counting as "shipped
hw".
-Daniel

> 
> So NAK, unless someone knows better.
> 
> > -
> >  	if (INTEL_INFO(dev)->gen >= 8 && i915.enable_execlists)
> >  		return 2;
> >  	else
> > -- 
> > 2.1.4
> 
> -- 
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch