[Intel-gfx] [PATCH 2/8] drm/i915: Migrate to safe iterators in error state capture

Tomas Elf tomas.elf at intel.com
Fri Oct 9 04:38:23 PDT 2015

On 09/10/2015 08:49, Chris Wilson wrote:
> On Thu, Oct 08, 2015 at 07:31:34PM +0100, Tomas Elf wrote:
>> Using safe list iterators alleviates the problem of unsynchronized driver list
>> manipulations while error state capture is in the process of traversing lists.
> Wrong, this does not make anything safe.
> -Chris

I know, I didn't say it would make it safe. As I said in an earlier 
mail: I use the word "alleviate" to indicate that we're reducing the 
problem scope and make fatal crashes less likely to occur but the 
underlying problem is still there. Since my focus is on TDR I didn't set 
out to solve the underlying problem, I only needed the error state 
capture code to not break my tests, which is why I set out to solve the 
crashes - not the underlying problem. If you have a solution for the 
underlying problem then that's another story.


More information about the Intel-gfx mailing list