[Intel-gfx] [PATCH 19/22] drm/i915: BDW: Pipe level Gamma correction

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 13 06:23:50 PDT 2015


On 10 October 2015 at 06:21, Sharma, Shashank <shashank.sharma at intel.com> wrote:
> On 10/10/2015 5:09 AM, Emil Velikov wrote:
>>
>> Hi Shashank,
>>
>> On 9 October 2015 at 20:29, Shashank Sharma <shashank.sharma at intel.com>
[snip]
>>> +       switch (num_samples) {
>>> +       case GAMMA_DISABLE_VALS:
>>> +
>>> +               /* Disable Gamma functionality on Pipe */
>>
>> Drop the extra newline between the case and the comment ? Here and below.
>>
> I was trying to make it look good :(
Beauty is in the eye of the beholder. The most important part here is
consistency.
Afaict there isn't (m)any i915 code the uses this approach, is there ?
Some of your other patches use this approach while others don't.

Regards,
Emil


More information about the Intel-gfx mailing list