[Intel-gfx] [PATCH 21/22] drm/i915: BDW: Pipe level degamma correction

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 13 06:39:52 PDT 2015


On 10 October 2015 at 06:31, Sharma, Shashank <shashank.sharma at intel.com> wrote:
> On 10/10/2015 5:19 AM, Emil Velikov wrote:
>>
>> Hi Shashank,
>>
>> On 9 October 2015 at 20:29, Shashank Sharma <shashank.sharma at intel.com>
>> wrote:
>>>
>>> BDW/SKL/BXT supports Degamma color correction feature, which
>>> linearizes the non-linearity due to gamma encoded color values.
>>> This will be applied before Color Transformation.
>>>
>>> This patch does the following:
>>> 1. Adds the core function to program DeGamma correction values for
>>>     BDW/SKL/BXT platform
>>> 2. Adds DeGamma correction macros/defines
>>>
>>> Signed-off-by: Shashank Sharma <shashank.sharma at intel.com>
>>> Signed-off-by: Kausal Malladi <kausalmalladi at gmail.com>
>>> ---
[snip]
>> Why don't you use switch statement here ?
>>
> Same as CHV degamma. Degamma has only 3 conditions (enable/disable and
> invalid), and we generally try to accommodate upto 3 condition within if ...
> else.
That rule sounds a bit funny bth. I'm not sure where it comes from,
but as is the codeflow isn't that obvious and the patches look
inconsistent with one another.

Regards,
Emil


More information about the Intel-gfx mailing list