[Intel-gfx] [PATCH 09/20] i915: switch from acpi_os_ioremap to memremap

Dan Williams dan.j.williams at intel.com
Tue Oct 13 09:24:26 PDT 2015


On Tue, Oct 13, 2015 at 1:24 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Oct 12, 2015 at 09:12:57PM +0000, Williams, Dan J wrote:
>> On Mon, 2015-10-12 at 09:01 +0200, Daniel Vetter wrote:
>> > On Fri, Oct 09, 2015 at 06:16:25PM -0400, Dan Williams wrote:
>> > > i915 expects the OpRegion to be cached (i.e. not __iomem), so explicitly
>> > > map it with memremap rather than the implied cache setting of
>> > > acpi_os_ioremap().
>> > >
>> > > Cc: Daniel Vetter <daniel.vetter at intel.com>
>> > > Cc: Jani Nikula <jani.nikula at linux.intel.com>
>> > > Cc: intel-gfx at lists.freedesktop.org
>> > > Cc: David Airlie <airlied at linux.ie>
>> > > Cc: dri-devel at lists.freedesktop.org
>> > > Signed-off-by: Dan Williams <dan.j.williams at intel.com>
>> >
>> > Assuming you've run sparse over this to make sure you've caught them all,
>> > and with the nit below addressed this is
>> >
>> > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>>
>> Indeed, re-running sparse again found a few conversions of ioread* I
>> missed as well as moving the force casting out of validate_vbt() to
>> find_vbt().
>>
>> > Feel free to pull v2 into whatever tree you think it's suitable for (but
>> > you can also resend and I'll pick it up).
>>
>> Please pick up v2 below.
>
> Queued for -next, thanks for the patch. Aside: Attached or separate mail
> seems easier, somehow git apply-mbox can't auto-eat this for of patch.
> -Daniel
>

"git am --scissors" should detect the "8<---" cut line.


More information about the Intel-gfx mailing list