[Intel-gfx] [PATCH v2] drm/i915: Drop i915_gem_obj_is_pinned() from set-cache-level

Chris Wilson chris at chris-wilson.co.uk
Wed Oct 14 03:56:01 PDT 2015


On Tue, Oct 13, 2015 at 03:52:57PM +0200, Daniel Vetter wrote:
> On Fri, Oct 09, 2015 at 02:43:21PM +0100, Tvrtko Ursulin wrote:
> > 
> > On 09/10/15 14:11, Chris Wilson wrote:
> > >Since the remove of the pin-ioctl, we only care about not changing the
> > >cache level on buffers pinned to the hardware as indicated by
> > >obj->pin_display. By knowing that only objects pinned to the hardware
> > >will have an elevated vma->pin_count, so we can coallesce many of the
> > >linear walks over the obj->vma_list.
> > >
> > >v2: Try and retrospectively add comments explaining the steps in
> > >rebinding the active VMA.
> > >
> > >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > >Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> > 
> > Very nice!
> > 
> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Queued for -next, thanks for the patch.

Note you also want

drm/i915: Move the mb() following release-mmap into release-mmap
http://patchwork.freedesktop.org/patch/61128/

to answer the question you posed in review.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list