[Intel-gfx] [PATCH 12/18] drm/i915: introduce intel_fbc_{enable, disable}

[Chris Wilson]

On Tue, Oct 20, 2015 at 11:49:58AM -0200, Paulo Zanoni wrote:
> These are the functions that lock/unlock FBC to/from a CRTC without
> changing the hardware state. The goal is to run once per modeset. For
> now the functions don't really do much, but we'll still move more
> stuff there, such as the stolen memory allocations.
> 
> With this, activate/deactivate will just start/stop FBC without
> changing its associated pipe. This is the same naming scheme we use in
> other features, such as PSR.
> 
> This will also help in case we decide to move FBC to pipe_config or
> something else later.

Pop quiz: can you summarise the rules on when the functions should be
called in the modeset sequence? Are there more places where you could
assert FBC state?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre