[Intel-gfx] [PATCH 7/7] drm/i915/bdw: sseu: fix sseu status parsing

Imre Deak imre.deak at intel.com
Wed Oct 21 08:40:37 PDT 2015


Currently when checking for fused off EUs we may ignore the EU count in
an enabled slice if there is any disabled slice preceding the enabled
one (with a lower slice ID). Perhaps this can't happen in reality, but
there is no reason to have this assumption built-in, the code is clearer
without it.

Signed-off-by: Imre Deak <imre.deak at intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 24504a3..1d43624 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -5054,7 +5054,7 @@ static void broadwell_sseu_device_status(struct drm_device *dev,
 				 sseu_subslice_total(stat);
 
 		/* subtract fused off EU(s) from enabled slice(s) */
-		for (s = 0; s < hweight32(stat->slice_mask); s++) {
+		for (s = 0; s < fls(stat->slice_mask); s++) {
 			u8 subslice_7eu = INTEL_INFO(dev)->sseu.subslice_7eu[s];
 
 			stat->eu_total -= hweight8(subslice_7eu);
-- 
2.1.4



More information about the Intel-gfx mailing list