[Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

[Chris Wilson]

On Fri, Oct 23, 2015 at 02:42:35PM +0300, David Weinehall wrote:
> Some tests should not be run by default, due to their slow,
> and sometimes superfluous, nature.
> 
> We still want to be able to run these tests though in some cases.
> Until now there's been no unified way of handling this. Remedy
> this by introducing the --with-slow-combinatorial option to
> igt_core, and use it in gem_concurrent_blit & kms_frontbuffer_tracking.
> ---
> diff --git a/tests/gem_concurrent_blit.c b/tests/gem_concurrent_blit.c
> index 1d2d787202df..311b6829e984 100644
> --- a/tests/gem_concurrent_blit.c
> +++ b/tests/gem_concurrent_blit.c
> @@ -931,9 +931,6 @@ run_basic_modes(const struct access_mode *mode,
>  	struct buffers buffers;
>  
>  	for (h = hangs; h->suffix; h++) {
> -		if (!all && *h->suffix)
> -			continue;
> -
>  		for (p = all ? pipelines : pskip; p->prefix; p++) {
>  			igt_fixture {
>  				batch = buffers_init(&buffers, mode, fd);

You didn't update this to skip the first few CPU vs CPU loops. Perhaps
if you just kill the all variable that would help.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre