[Intel-gfx] [PATCH] drm/i915: Treat ringbuffer vaddress type properly when vmapped

Mika Kuoppala mika.kuoppala at linux.intel.com
Fri Oct 30 05:28:26 PDT 2015


Chris Wilson <chris at chris-wilson.co.uk> writes:

> On Fri, Oct 30, 2015 at 01:39:24PM +0200, Mika Kuoppala wrote:
>> commit def0c5f6b0cd ("drm/i915: Map the ringbuffer using WB on LLC machines")
>> enhanced ringbuffer access by vmapping the object instead of doing ioremap.
>> 
>> The address space annotations however have been and should
>> remain to be __iomem, in order to get warnings if we
>> dereference the virtual addresses directly instead of using
>> proper accessors.
>> 
>> To keep sparse happy, use explicit casts to __iomem and back
>> when we are wb capable.
>
> Or you could review the patch on list to remove the incorrect iomem.

Yes, ignore this patch.

> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list