[Intel-gfx] [PATCH 1/4] drm: Add a non-locking version of drm_kms_helper_poll_enable().
Egbert Eich
eich at suse.com
Tue Sep 1 21:57:21 PDT 2015
Lukas Wunner writes:
> Hi Egbert,
>
> On Wed, Sep 02, 2015 at 12:10:19AM +0200, Egbert Eich wrote:
> > Lukas Wunner writes:
> > > On Tue, Sep 01, 2015 at 10:21:32PM +0200, Egbert Eich wrote:
> > > > drm_kms_helper_poll_enable() was converted to lock the mode_config
> > > > mutex in commit 8c4ccc4ab6f64e859d4ff8d7c02c2ed2e956e07f
> > > > ("drm/probe-helper: Grab mode_config.mutex in poll_init/enable").
> > > >
> > > > This disregarded the cases where this function is called from a context
> > > > where this mutex is already locked.
> > >
> > > Which ones would that be?
> >
> > Have you missed the next patch in the series?
>
> Sorry, I should have asked more precisely: Is this the only one?
> If so it may make sense to modify i915_hotplug_work_func or
> intel_hpd_irq_storm_disable instead.
>
The non-locking version existed before. I've just exported it so it cah
be used by drivers.
Moreover this is a helper function - why should it be restricted to
callers which don't have the mode_config mutex grabbed?
I could be talked into changing the log message.
Egbert.
More information about the Intel-gfx
mailing list