[Intel-gfx] [RFC PATCH] drm/i915: Use universal planes for cursor on skylake.

Maarten Lankhorst maarten at mblankhorst.nl
Wed Sep 2 07:09:03 PDT 2015


Op 02-09-15 om 11:15 schreef Daniel Vetter:
> On Thu, Aug 27, 2015 at 12:08:30PM +0200, Maarten Lankhorst wrote:
>> This appears to make all the cursor tests really slow because of the many calls to skl_update_wm
>> when the cursor plane visibility is changed. It performs does 3 vblanks each time it's called, and
>> it's probably called more than once on each update.
> On all other platforms wm updates (right now at least) don't do any vblank
> waits, which means changing cursors actually _does_ cause tons of
> underruns. Can we perhaps add a hack in skl to do the same (maybe just for
> cursors) so that we can get this in? There's lots other work that really
> wants proper universal planes ...
>
Well this is easily fixed by moving it to unpin_work, so it runs after the next vblank interrupt.

If that patch series is too far out annotate wm changed,
kill all intel_wait_vblank calls inside post_plane_update and run that function after drm_atomic_helper_wait_for_vblanks.

~Maarten


More information about the Intel-gfx mailing list