[Intel-gfx] 4.1->4.2 regression : intel_display.c:12324 check_crtc_state warning

Wed Sep 2 13:31:24 PDT 2015

>> Sep  2 18:10:26 t44 kernel: [drm:check_crtc_state [i915]] *ERROR* mismatch in ips_enabled (expected 1, found 0)

It is due to ips_enabled mismatch in crtc_state. 
I can't think how below patch is triggering mismatch in ips_enabled.

> -----Original Message-----
> From: Toralf Förster [mailto:toralf.foerster at gmx.de]
> Sent: Wednesday, September 02, 2015 1:18 PM
> To: Konduru, Chandra; Roper, Matthew D; daniel.vetter at ffwll.ch
> Cc: intel-gfx
> Subject: 4.1->4.2 regression : intel_display.c:12324 check_crtc_state warning
> 
> The following commit was bisected and tested to be the first bad commit which
> causes the warning as seen below at a ThinkPad T40s:
> 
> 
> 
> commit a1b2278e4dfcd2dbea85e319ebf73a6b7b2f180b
> Author: Chandra Konduru <chandra.konduru at intel.com>
> Date:   Tue Apr 7 15:28:45 2015 -0700
> 
>     drm/i915: skylake panel fitting using shared scalers
> 
>     Enabling skylake panel fitting feature using shared scalers
> 
>     v2:
>     -added force detach parameter for pfit disable purpose (me)
>     -read crtc scaler state from hw state (Daniel)
>     -replaced both skylake_pfit_enable and disable with skylake_pfit_update (me)
>     -added scaler id check to intel_pipe_config_compare (Daniel)
> 
>     v3:
>     -updated function header to kerneldoc format (Matt)
>     -dropped need_scaling checks (Matt)
> 
>     v4:
>     -move clearing of scaler id from commit path to check path (Matt)
>     -updated colorkey checks based on recent updates (me)
>     -squashed scaler check while enabling colorkey to here (me)
>     -use values in plane_state->src as regular integers (me)
>     -changes made not to modify state in commit path (Matt)
> 
>     v5:
>     -squashed helper function to update scaler users to here (Matt)
>     -squashed helper function to detach scaler to here (Matt, me)
>     -changes to align with updated scaler structures (Matt, me)
> 
>     Signed-off-by: Chandra Konduru <chandra.konduru at intel.com>
>     Reviewed-by: Matt Roper <matthew.d.roper at intel.com>
>     Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> 
> 
> 
> 
> 
> From the syslog:
> 
> Sep  2 18:10:17 t44 kernel: ------------[ cut here ]------------
> Sep  2 18:10:17 t44 kernel: WARNING: CPU: 2 PID: 1252 at
> drivers/gpu/drm/i915/intel_display.c:12324 check_crtc_state+0x7fa/0xf50
> [i915]()
> Sep  2 18:10:17 t44 kernel: pipe state doesn't match!
> Sep  2 18:10:17 t44 kernel: Modules linked in: nf_conntrack_ipv6 nf_defrag_ipv6
> ip6table_filter ip6_tables ipt_MASQUERADE nf_nat_masquerade_ipv4
> nf_log_ipv4 nf_log_common xt_LOG xt_limit ipt_REJECT nf_reject_ipv4
> xt_recent xt_tcpudp xt_conntrack iptable_raw iptable_nat nf_conntrack_ipv4
> nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_filter ip_tables x_tables
> nfsd auth_rpcgss oid_registry lockd grace ctr ccm sunrpc af_packet bridge stp llc
> tun rc_dib0700_rc5 hid_generic hid_cherry usbhid hid dib7000p
> dvb_usb_dib0700 dib3000mc dvb_usb dvb_core dib0070 dib7000m
> dibx000_common dib0090 rc_core snd_hda_codec_generic arc4 coretemp
> x86_pkg_temp_thermal kvm_intel kvm rtsx_pci_sdmmc mmc_core evdev
> jitterentropy_rng hmac drbg aesni_intel aes_x86_64 glue_helper lrw gf128mul
> psmouse ablk_helper cryptd atkbd pcspkr iwlmvm
> Sep  2 18:10:17 t44 kernel:  wmi mac80211 i915 fbcon bitblit cfbfillrect cfbimgblt
> softcursor font i2c_algo_bit cfbcopyarea snd_hda_intel snd_hda_codec battery
> thinkpad_acpi tpm_tis ehci_pci drm_kms_helper ac nvram snd_hda_core iwlwifi
> hwmon i2c_i801 snd_pcm tpm cfg80211 drm video rtsx_pci rfkill intel_gtt
> xhci_pci thermal xhci_hcd agpgart ehci_hcd button fb usbcore snd_timer
> i2c_core e1000e fbdev lpc_ich snd usb_common mfd_core soundcore processor
> Sep  2 18:10:17 t44 kernel: CPU: 2 PID: 1252 Comm: X Tainted: G        W
> 4.2.0+ #4
> Sep  2 18:10:17 t44 kernel: Hardware name: LENOVO
> 20AQCTO1WW/20AQCTO1WW, BIOS GJET83WW (2.33 ) 03/09/2015
> Sep  2 18:10:17 t44 kernel:  ffffffffc05f0f18 ffff88032a6ab828 ffffffff814cef01
> ffff88032a6ab870
> Sep  2 18:10:17 t44 kernel:  ffff88032a6ab860 ffffffff810503b6 ffff88032fdcec00
> ffff8800ad66f800
> Sep  2 18:10:17 t44 kernel:  ffff8800ad040000 ffff8800ad66fc98
> ffff8800adfeb000 ffff88032a6ab8c0
> Sep  2 18:10:17 t44 kernel: Call Trace:
> Sep  2 18:10:17 t44 kernel:  [<ffffffff814cef01>] dump_stack+0x44/0x55
> Sep  2 18:10:17 t44 kernel:  [<ffffffff810503b6>]
> warn_slowpath_common+0x86/0xc0
> Sep  2 18:10:17 t44 kernel:  [<ffffffff8105043c>] warn_slowpath_fmt+0x4c/0x50
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc05878da>] check_crtc_state+0x7fa/0xf50
> [i915]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc059a21d>]
> intel_modeset_check_state+0x28d/0xae0 [i915]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc0594906>] ?
> __intel_set_mode+0x906/0xb30 [i915]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc0595d32>] ?
> intel_modeset_compute_config+0x362/0xb60 [i915]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc059b68d>]
> intel_crtc_set_config+0x3ed/0x5a0 [i915]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc029cc07>]
> drm_mode_set_config_internal+0x67/0x110 [drm]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc02a068d>] drm_mode_setcrtc+0xdd/0x500
> [drm]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc02923c3>] drm_ioctl+0x363/0x680 [drm]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc02a05b0>] ?
> drm_mode_setplane+0x1c0/0x1c0 [drm]
> Sep  2 18:10:17 t44 kernel:  [<ffffffffc06864a2>] ?
> ieee80211_rx_irqsafe+0x32/0x50 [mac80211]
> Sep  2 18:10:17 t44 kernel:  [<ffffffff8117152d>] do_vfs_ioctl+0x2cd/0x4c0
> Sep  2 18:10:17 t44 kernel:  [<ffffffff810d449f>] ?
> __audit_syscall_entry+0xaf/0x100
> Sep  2 18:10:17 t44 kernel:  [<ffffffff81001056>] ?
> do_audit_syscall_entry+0x66/0x70
> Sep  2 18:10:17 t44 kernel:  [<ffffffff810015b6>] ?
> syscall_trace_enter_phase1+0x126/0x140
> Sep  2 18:10:17 t44 kernel:  [<ffffffff81171761>] SyS_ioctl+0x41/0x70
> Sep  2 18:10:17 t44 kernel:  [<ffffffff81001915>] ?
> syscall_return_slowpath+0x45/0x110
> Sep  2 18:10:17 t44 kernel:  [<ffffffff814d5517>]
> entry_SYSCALL_64_fastpath+0x12/0x6a
> Sep  2 18:10:17 t44 kernel: ---[ end trace 310af98b8519434e ]---
> Sep  2 18:10:24 t44 logger: /home/tfoerste/workspace/bin/monitor.sh: started
> with int
> Sep  2 18:10:24 t44 logger: /home/tfoerste/workspace/bin/monitor.sh: n=2
> choosed DP2-2
> Sep  2 18:10:26 t44 kernel: [drm:check_crtc_state [i915]] *ERROR* mismatch in
> ips_enabled (expected 1, found 0)
> Sep  2 18:10:26 t44 kernel: ------------[ cut here ]------------
> 
> 
> --
> Toralf, pgp key: 872AE508 0076E94E