[Intel-gfx] [PATCH 0/3] remove crtc<->pipe mapping code

Thomas Wood thomas.wood at intel.com
Tue Sep 8 04:07:22 PDT 2015


On 4 September 2015 at 19:22, Micah Fedke <micah.fedke at collabora.co.uk> wrote:
> This patchset removes the code that looks up a pipe number from a crtc ID.  The
> pipe number is equivalent to the index of the crtc in the array of crtcs
> returned by the kernel for a drmModeGetResources() call.  This may not have
> been the case when these lookups were written, but it is the de facto behavior
> nowadays.  Eliminating the intel-specific ioctl used in this lookup also helps
> simplify the process of converting tests to work on multiple platforms.

Is there a libdrm version that can be relied upon for this behaviour?
Should the required version be updated?

>
> The lookup is happening in the kmstest_get_pipe_from_crtc_id() lib helper
> function, and in two different open-coded snippets.  Each fix received its own
> patch.
>
> These updates affect kms_flip, kms_render, kms_3d, testdisplay, drm_read and
> overlay
>
> Micah Fedke (3):
>   lib: update kmstest_get_pipe_from_crtc_id     This function uses an
>     intel-specific ioctl to fetch a mapping between pipes and     crtc
>     ids, but this technique is outdated as the crtc id is now always
>     equivalent to its index in the array of crtcs returned by the
>     kernel.
>   tests/drm_read: remove manual crtc<->pipe mapping from drm_read test
>       the crtc id is now always equivalent to its index in the array of
>     crtcs returned by the kernel
>   overlay: remove crtc<->pipe mapping code from kms-overlay     the crtc
>     id is now always equivalent to its index in the array of crtcs
>     returned by the kernel
>
>  lib/igt_kms.c             | 33 ++++++++++++++++++++++++---------
>  overlay/Makefile.am       |  4 ++--
>  overlay/kms/kms-overlay.c |  7 ++-----
>  tests/drm_read.c          | 43 +++++++++++++------------------------------
>  4 files changed, 41 insertions(+), 46 deletions(-)
>
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list