[Intel-gfx] [PATCH 1/2] drm/i915: WaEnableForceRestoreInCtxtDescForVCS is for video engines only

[Arun Siluvery]

On 04/09/2015 12:59, Michel Thierry wrote:
> Also check for correct revision id in each Gen9 platform (SKL until B0
> and BXT until A0).
>
> Cc: Nick Hoath <nicholas.hoath at intel.com>
> Signed-off-by: Michel Thierry <michel.thierry at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_lrc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 28a712e..d8b605f 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -301,10 +301,10 @@ uint64_t intel_lr_context_descriptor(struct intel_context *ctx,
>   	/* desc |= GEN8_CTX_FORCE_RESTORE; */
>
>   	/* WaEnableForceRestoreInCtxtDescForVCS:skl */
> -	if (IS_GEN9(dev) &&
> -	    INTEL_REVID(dev) <= SKL_REVID_B0 &&
> -	    (ring->id == BCS || ring->id == VCS ||
> -	    ring->id == VECS || ring->id == VCS2))
> +	/* WaEnableForceRestoreInCtxtDescForVCS:bxt */
> +	if (((IS_SKYLAKE(dev) && INTEL_REVID(dev) <= SKL_REVID_B0) ||
> +	     (IS_BROXTON(dev) && INTEL_REVID(dev) == BXT_REVID_A0)) &&
> +	    (ring->id == VCS || ring->id == VCS2))
>   		desc |= GEN8_CTX_FORCE_RESTORE;
>
>   	return desc;
>
Maybe we can drop SKL as they are early revisions? even if we choose to 
retain it looks good to me,
Reviewed-by: Arun Siluvery <arun.siluvery at linux.intel.com>

regards
Arun