[Intel-gfx] [PATCH 0/1] drm/i915: connector specific backlight hooks for eDP/DSI

Jani Nikula jani.nikula at intel.com
Mon Sep 14 04:03:47 PDT 2015


Hi all -

This patch moves the backlight hooks from dev_priv->display to
intel_panel. This should enable connector specific backlight control
mechanisms, such as DPCD for eDP and DCS commands for DSI, to be neatly
connected to the existing backlight infrastructure.

Basically it should be sufficient to just point the hooks at the
specific backlight control mechanisms, and let the generic code be. You
can still add those mechanisms to separate files. There should be very
little to no special casing anywhere, apart from the hooks themselves.

This is in response to the two new backlight control mechanisms in
flight, for eDP [1] and DSI [2]. We should not quickly bolt on these
mechanisms when there's a better way with not much extra effort.

This patch is untested, but there's no rocket science here. I just
wanted this quickly out.

BR,
Jani.


[1] http://mid.gmane.org/1441894302-28475-1-git-send-email-yetundex.adebisi@intel.com
[2] http://mid.gmane.org/1441946868-4985-1-git-send-email-m.deepak@intel.com


Jani Nikula (1):
  drm/i915: make backlight hooks connector specific

 drivers/gpu/drm/i915/i915_drv.h      |   9 ---
 drivers/gpu/drm/i915/intel_display.c |   2 -
 drivers/gpu/drm/i915/intel_dp.c      |   2 +-
 drivers/gpu/drm/i915/intel_drv.h     |  13 +++-
 drivers/gpu/drm/i915/intel_panel.c   | 116 +++++++++++++++++++----------------
 5 files changed, 74 insertions(+), 68 deletions(-)

-- 
2.1.4



More information about the Intel-gfx mailing list