[Intel-gfx] [PATCH] drm/i915: CABC support for backlight control

[Jani Nikula]

On Mon, 14 Sep 2015, "Deepak, M" <m.deepak at intel.com> wrote:
>>-----Original Message-----
>>From: Jani Nikula [mailto:jani.nikula at linux.intel.com]
>>Sent: Monday, September 14, 2015 5:51 PM
>>To: Deepak, M; intel-gfx at lists.freedesktop.org
>>Cc: Deepak, M
>>Subject: Re: [Intel-gfx] [PATCH] drm/i915: CABC support for backlight control
>>
>>On Mon, 14 Sep 2015, Deepak M <m.deepak at intel.com> wrote:
>>> diff --git a/include/video/mipi_display.h
>>> b/include/video/mipi_display.h index ddcc8ca..5b8eeec 100644
>>> --- a/include/video/mipi_display.h
>>> +++ b/include/video/mipi_display.h
>>> @@ -117,6 +117,14 @@ enum {
>>>  	MIPI_DCS_GET_SCANLINE		= 0x45,
>>>  	MIPI_DCS_READ_DDB_START		= 0xA1,
>>>  	MIPI_DCS_READ_DDB_CONTINUE	= 0xA8,
>>> +	MIPI_DCS_CABC_LEVEL_RD          = 0x52,
>>> +	MIPI_DCS_CABC_MIN_BRIGHTNESS_RD = 0x5F,
>>> +	MIPI_DCS_CABC_CONTROL_RD        = 0x56,
>>> +	MIPI_DCS_CABC_CONTROL_BRIGHT_RD = 0x54,
>>> +	MIPI_DCS_CABC_LEVEL_WR          = 0x51,
>>> +	MIPI_DCS_CABC_MIN_BRIGHTNESS_WR = 0x5E,
>>> +	MIPI_DCS_CABC_CONTROL_WR        = 0x55,
>>> +	MIPI_DCS_CABC_CONTROL_BRIGHT_WR = 0x53,
>>
>>These changes need to be a separate patch. And what's the spec reference, I
>>can't find these.
>>
> [Deepak M] The HLD can be found in the link https://securewiki.ith.intel.com/display/GfxDisplay/MIPI+Display (it is under Intel firewall)

If you want to add stuff to include/video/mipi_display.h it has to be
standard DCS commands, in actual MIPI issued specs, not something
internal to us.

Manufacturer specific commands (usually referred to as MCS) need to be
hidden in manufacturer specific files in the driver.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center